Skip to content

Conversation

nicolas-grekas
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Related tickets -
Documentation TBD
License MIT

Let's be more explicit about the move to PSR-18.

I'm not throwing a runtime deprecation notice because that might be too annoying for the existing clients, especially those in the php-http/* namespace.

@nicolas-grekas
Copy link
Contributor Author

Sibling PR at php-http/message-factory#42

@dbu dbu merged commit 822dbc9 into php-http:2.x Apr 14, 2023
@nicolas-grekas nicolas-grekas deleted the deprec-sync branch April 17, 2023 08:24
nicolas-grekas added a commit to symfony/symfony that referenced this pull request Apr 17, 2023
…(nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[ErrorHandler] Don't throw deprecations for HttplugClient

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #50035
| License       | MIT
| Doc PR        | -

Follows php-http/httplug#171 and #47832

Required to make the CI green again.

Commits
-------

bafb237 [ErrorHandler] Don't throw deprecations for HttplugClient
fabpot added a commit to symfony/symfony that referenced this pull request Apr 26, 2023
…s deprecated (nicolas-grekas)

This PR was merged into the 6.3 branch.

Discussion
----------

[HttpClient] Add PSR-18 to HttplugClient since HTTPlug is deprecated

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Relates to php-http/httplug#171

Commits
-------

ab9cefc [HttpClient] Add PSR-18 to HttplugClient since HTTPlug is deprecated
nicolas-grekas added a commit to symfony/symfony that referenced this pull request May 2, 2023
… (nicolas-grekas)

This PR was merged into the 5.4 branch.

Discussion
----------

[ErrorHandler] Skip Httplug deprecations for HttplugClient

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Follows #50036 and php-http/httplug#171

Commits
-------

159bf0b [ErrorHandler] Skip Httplug deprecations for HttplugClient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants